Skip to content

fix(react/runtime): un-revert #239 'batch multiple patches for main thread communication'#640

Merged
Yradex merged 1 commit intomainfrom
revert-637-lifecycle/fix
Apr 27, 2025
Merged

fix(react/runtime): un-revert #239 'batch multiple patches for main thread communication'#640
Yradex merged 1 commit intomainfrom
revert-637-lifecycle/fix

Conversation

@Yradex
Copy link
Copy Markdown
Collaborator

@Yradex Yradex commented Apr 27, 2025

Reverts #637

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: b7741ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Yradex Yradex enabled auto-merge April 27, 2025 11:32
@Yradex Yradex changed the title Revert "fix(react/runtime): revert #239 'batch multiple patches for main thread communication'" fix(react/runtime): un-revert #239 'batch multiple patches for main thread communication' Apr 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.95238% with 12 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/react/runtime/src/lynx/tt.ts 0.00% 6 Missing ⚠️
...ckages/react/runtime/src/lifecycle/patch/commit.ts 92.00% 4 Missing ⚠️
packages/react/runtime/src/lifecycle/render.ts 75.00% 1 Missing ⚠️
packages/react/runtime/src/lynx-api.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Yradex Yradex requested review from colinaaa and hzy April 27, 2025 11:37
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2025

CodSpeed Performance Report

Merging #640 will not alter performance

Comparing revert-637-lifecycle/fix (b7741ad) with main (0be475d)

Summary

✅ 1 untouched benchmarks

@Yradex Yradex added this pull request to the merge queue Apr 27, 2025
Merged via the queue into main with commit 2698532 Apr 27, 2025
32 of 33 checks passed
@Yradex Yradex deleted the revert-637-lifecycle/fix branch April 27, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinaaa colinaaa colinaaa approved these changes

@hzy hzy Awaiting requested review from hzy hzy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yradex @colinaaa